From ea7ce9a507b92ce6e3046ffc669a4ff7939b139d Mon Sep 17 00:00:00 2001 From: John Doty Date: Thu, 10 May 2012 21:34:03 -0700 Subject: [PATCH] Fix it so that pins show up on IE. In pinry.js, reference is made to image.width and image.height properties, neither of which exist. They are used to compute the target height of the image, by computing the aspect ratio image.width/image.height. Unfortunately, undefined/undefined yields NaN, and so we end up writing "height='NaN'" into the HTML. It looks like webkit (at least chrome) ignores it when the height attribute on an element is set to NaN, but Internet Explorer treats it as zero. That's why it didn't look broken on other browsers. --- pinry/core/static/core/js/pinry.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pinry/core/static/core/js/pinry.js b/pinry/core/static/core/js/pinry.js index b01a5e6..fd03428 100644 --- a/pinry/core/static/core/js/pinry.js +++ b/pinry/core/static/core/js/pinry.js @@ -61,7 +61,7 @@ $(window).ready(function () { image = data[i]; html += '
'; html += ''; - html += ''; + html += ''; html += ''; html += '

'+image.description+'

'; html += '
';