Browse Source

Fix: Should allow null-valur for some field

pull/139/head
winkidney 5 years ago
parent
commit
6f6d858f8c
1 changed files with 17 additions and 4 deletions
  1. +17
    -4
      core/drf_api.py

+ 17
- 4
core/drf_api.py View File

@@ -1,5 +1,6 @@
from django.conf import settings from django.conf import settings
from rest_framework import serializers from rest_framework import serializers
from rest_framework.exceptions import ValidationError
from taggit.models import Tag from taggit.models import Tag


from core.models import Image from core.models import Image
@@ -103,17 +104,29 @@ class PinSerializer(serializers.HyperlinkedModelSerializer):
image_by_id = serializers.PrimaryKeyRelatedField( image_by_id = serializers.PrimaryKeyRelatedField(
queryset=Image.objects.all(), queryset=Image.objects.all(),
write_only=True, write_only=True,
required=False,
) )


def validate(self, attrs):
if 'url' not in attrs and 'image_by_id' not in attrs:
raise ValidationError(
detail={
"url-or-image": "Either url or image_by_id is required."
},
)
return attrs

def create(self, validated_data): def create(self, validated_data):
submitter = self.context['request'].user submitter = self.context['request'].user
image = validated_data.pop("image_by_id")
if 'url' in validated_data and validated_data['url']: if 'url' in validated_data and validated_data['url']:
url = validated_data['url']
image = Image.objects.create_for_url( image = Image.objects.create_for_url(
validated_data['url'],
validated_data['referer'],
url,
validated_data.get('referer', url),
) )
tags = validated_data.pop('tag_list')
else:
image = validated_data.pop("image_by_id")
tags = validated_data.pop('tag_list', [])
pin = Pin.objects.create(submitter=submitter, image=image, **validated_data) pin = Pin.objects.create(submitter=submitter, image=image, **validated_data)
if tags: if tags:
pin.tags.set(*tags) pin.tags.set(*tags)


Loading…
Cancel
Save