Selaa lähdekoodia

Clear password generation form when user update his master password

pull/448/head
Guillaume Vincent 5 vuotta sitten
vanhempi
commit
96b5704a4d
6 muutettua tiedostoa jossa 84 lisäystä ja 56 poistoa
  1. +1
    -1
      packages/lesspass-pure/cypress.json
  2. +14
    -1
      packages/lesspass-pure/cypress/integration/passwordGeneration.spec.js
  3. +1
    -1
      packages/lesspass-pure/dist/lesspass.min.js
  4. +1
    -1
      packages/lesspass-pure/package.json
  5. +63
    -52
      packages/lesspass-pure/src/components/InputSite.test.js
  6. +4
    -0
      packages/lesspass-pure/src/views/PasswordGenerator.vue

+ 1
- 1
packages/lesspass-pure/cypress.json Näytä tiedosto

@@ -1,3 +1,3 @@
{
"baseUrl": "http://localhost:8080"
"baseUrl": "http://localhost:8000"
}

+ 14
- 1
packages/lesspass-pure/cypress/integration/passwordGeneration.spec.js Näytä tiedosto

@@ -112,7 +112,7 @@ describe("Password Generation", function() {
.type("{enter}");
cy.get("#generated-password").should("have.value", "hjV@\\5ULp3bIs,6B");
});
it.only("should keep site field in sync nrt_441", function() {
it("should keep site field in sync nrt_441", function() {
cy.visit("/");
cy.get("#login").type("user");
cy.get("#passwordField").type("password");
@@ -127,4 +127,17 @@ describe("Password Generation", function() {
cy.get("#generatePassword__btn").click();
cy.get("#generated-password").should("have.value", "ZT^IK2e!t@k$9`*)");
});
it("should clear password generated when master password change", function() {
cy.visit("/");
cy.get("#siteField").type("example.org");
cy.get("#login").type("user");
cy.get("#passwordField").type("password");
cy.get("#generatePassword__btn").should("be.visible");
cy.get("#generatePassword__btn").click();
cy.get("#copyPasswordButton").should("be.visible");
cy.get("#generatePassword__btn").should("not.be.visible");
cy.get("#passwordField").type("password");
cy.get("#copyPasswordButton").should("not.be.visible");
cy.get("#generatePassword__btn").should("be.visible");
});
});

+ 1
- 1
packages/lesspass-pure/dist/lesspass.min.js
File diff suppressed because it is too large
Näytä tiedosto


+ 1
- 1
packages/lesspass-pure/package.json Näytä tiedosto

@@ -13,7 +13,7 @@
"cypress:open": "cypress open",
"test": "npm run test:unit",
"test:unit": "jest",
"test:e2e": "npm run build && start-server-and-test start http://localhost:8080 cypress:run"
"test:e2e": "start-server-and-test dev http://localhost:8000 cypress:run"
},
"babel": {
"presets": [


packages/lesspass-pure/src/components/input-site.test.js → packages/lesspass-pure/src/components/InputSite.test.js Näytä tiedosto

@@ -1,72 +1,81 @@
import {mount} from '@vue/test-utils'
import InputSite from './InputSite.vue'
import { mount } from "@vue/test-utils";
import InputSite from "./InputSite.vue";

jest.mock('../services/url-parser');
import {getSuggestions} from '../services/url-parser';
jest.mock("../services/url-parser");
import { getSuggestions } from "../services/url-parser";


const createWrapper = data => mount({
data: () => {
return {
site: "",
passwords: [],
...data
}
},
template: '<input-site v-model="site" v-bind:passwords="passwords" v-bind:label="\'Site\'"></input-site>',
components: {'input-site': InputSite}
});
const createWrapper = data =>
mount({
data: () => {
return {
site: "",
passwords: [],
...data
};
},
template:
'<input-site v-model="site" v-bind:passwords="passwords" v-bind:label="\'Site\'"></input-site>',
components: { "input-site": InputSite }
});

const optionsFor = wrapper => wrapper.findAll("div.awesomplete li");
const inputField = wrapper => wrapper.find('#siteField');
const inputField = wrapper => wrapper.find("#siteField");

describe('InputSite', () => {
describe("InputSite", () => {
beforeEach(() => {
getSuggestions.mockImplementation(() => []);
});
it('fills the input with the value property', () => {
const wrapper = createWrapper({site: 'lesspass.com'});
it("fills the input with the value property", () => {
const wrapper = createWrapper({ site: "lesspass.com" });
const input = inputField(wrapper);
expect(input.element.value).toBe("lesspass.com")
expect(input.element.value).toBe("lesspass.com");
});

describe('autocomplete', function () {
describe('search', () => {
it('filters according to site name', () => {
describe("autocomplete", function() {
describe("search", () => {
it("filters according to site name", () => {
const wrapper = createWrapper({
passwords: [{site: "lesspass", login: "xavier"},
{site: "wrongsite", login: "xavier"}]
passwords: [
{ site: "lesspass", login: "xavier" },
{ site: "wrongsite", login: "xavier" }
]
});
inputField(wrapper).setValue("le");
let options = optionsFor(wrapper);
expect(options.length).toBe(1);
expect(options.at(0).text()).toBe("lesspass xavier")
expect(options.at(0).text()).toBe("lesspass xavier");
});
it(`shows options that are contained in the user's value`, () => {
const wrapper = createWrapper({passwords: [{site: "lesspass", login: "xavier"}]});
const wrapper = createWrapper({
passwords: [{ site: "lesspass", login: "xavier" }]
});
inputField(wrapper).setValue("www.lesspass.com");
let options = optionsFor(wrapper);
expect(options.length).toBe(1);
expect(options.at(0).text()).toBe("lesspass xavier")
expect(options.at(0).text()).toBe("lesspass xavier");
});
it('filters using suggestion', () => {
it("filters using suggestion", () => {
getSuggestions.mockImplementation(() => []);
const wrapper = createWrapper();
getSuggestions.mockImplementation(() => ["lesspass"]);
inputField(wrapper).setValue("lesspass.com");
let options = optionsFor(wrapper);
expect(options.length).toBe(1);
expect(options.at(0).text()).toBe("lesspass")
expect(options.at(0).text()).toBe("lesspass");
});
it('shows site and login in the list', () => {
const wrapper = createWrapper({passwords: [{site: "lesspass", login: "xavier"}]});
it("shows site and login in the list", () => {
const wrapper = createWrapper({
passwords: [{ site: "lesspass", login: "xavier" }]
});
inputField(wrapper).setValue("le");
let options = optionsFor(wrapper);
expect(options.length).toBe(1);
expect(options.at(0).text()).toBe("lesspass xavier")
expect(options.at(0).text()).toBe("lesspass xavier");
});
it(`doesn't use login`, () => {
const wrapper = createWrapper({passwords: [{site: "lesspass", login: "xavier"}]});
const wrapper = createWrapper({
passwords: [{ site: "lesspass", login: "xavier" }]
});
inputField(wrapper).setValue("xa");
let options = optionsFor(wrapper);
expect(options.length).toBe(0);
@@ -74,10 +83,10 @@ describe('InputSite', () => {
it(`prints options sorted by site then login`, () => {
const wrapper = createWrapper({
passwords: [
{site: "lesspass", login: "guillaume"},
{site: "passless", login: "xavier"},
{site: "passless", login: "guillaume"},
{site: "lesspass", login: "xavier"},
{ site: "lesspass", login: "guillaume" },
{ site: "passless", login: "xavier" },
{ site: "passless", login: "guillaume" },
{ site: "lesspass", login: "xavier" }
]
});
inputField(wrapper).setValue("le");
@@ -89,46 +98,48 @@ describe('InputSite', () => {
expect(options.at(3).text()).toBe("passless xavier");
});
});
describe('completion', () => {

describe('when selecting password', () => {
describe("completion", () => {
describe("when selecting password", () => {
let wrapper;
beforeEach(() => {
wrapper = createWrapper({passwords: [{site: "lesspass", login: "xavier"}]});
wrapper = createWrapper({
passwords: [{ site: "lesspass", login: "xavier" }]
});
inputField(wrapper).setValue("le");
const options = optionsFor(wrapper);
options.at(0).trigger('click');
options.at(0).trigger("click");
});
it('completes field', () => {
it("completes field", () => {
expect(inputField(wrapper).element.value).toBe("lesspass");
});
it('emits a "passwordProfileSelected" with the value', () => {
const emitted = wrapper.find(InputSite).emitted();
const profileSelected = emitted['passwordProfileSelected'];
const profileSelected = emitted["passwordProfileSelected"];
expect(profileSelected.length).toBe(1);
expect(profileSelected[0]).toEqual([{site: "lesspass", login: "xavier"}]);
expect(profileSelected[0]).toEqual([
{ site: "lesspass", login: "xavier" }
]);
});
});
describe('when selecting suggestion', () => {
describe("when selecting suggestion", () => {
let wrapper;
beforeEach(() => {
getSuggestions.mockImplementation(() => ["lesspass"]);
wrapper = createWrapper();
inputField(wrapper).setValue("le");
const options = optionsFor(wrapper);
options.at(0).trigger('click');
options.at(0).trigger("click");
});
it('completes field', () => {
it("completes field", () => {
expect(inputField(wrapper).element.value).toBe("lesspass");
});
it('emits a "suggestionSelected" with site value', () => {
const emitted = wrapper.find(InputSite).emitted();
const profileSelected = emitted['suggestionSelected'];
const profileSelected = emitted["suggestionSelected"];
expect(profileSelected.length).toBe(1);
expect(profileSelected[0]).toEqual(["lesspass"]);
});
});
});
});

});

+ 4
- 0
packages/lesspass-pure/src/views/PasswordGenerator.vue Näytä tiedosto

@@ -157,6 +157,10 @@ export default {
this.cleanErrors();
},
deep: true
},
masterPassword: function (newMasterPassword, oldMasterPassword) {
this.masterPassword = newMasterPassword;
this.cleanErrors();
}
},
methods: {


Ladataan…
Peruuta
Tallenna