Browse Source

Reduce size of a buffer to quiet a spurious warning. Fixes #133.

A recent compiler complains about the sprintf() in authenticate() being able to
write up to 1023 bytes into challenge, which is not possible given that getChallenge()
returns a string 10 bytes smaller than whatever string is in its 1024 byte buffer.
Reducing the size of the buffer in getChallenge() quiets the warning.  It should not
affect anything else, as the challenge string is used as a salt that must be <= 96 bits.
pull/134/head
Mark Liffiton 3 years ago
parent
commit
8f7b99f0f5
1 changed files with 2 additions and 2 deletions
  1. +2
    -2
      wiringPi/drcNet.c

+ 2
- 2
wiringPi/drcNet.c View File

@@ -76,12 +76,12 @@ static int remoteReadline (int fd, char *buf, int max)

static char *getChallenge (int fd)
{
static char buf [1024] ;
static char buf [512] ;
int num ;

for (;;)
{
if ((num = remoteReadline (fd, buf, 1023)) < 0)
if ((num = remoteReadline (fd, buf, 511)) < 0)
return NULL ;
buf [num] = 0 ;



Loading…
Cancel
Save